Download file on your website

i made my script php file for file download and it's working perfect in locahost ,however in the server side it is not working i tryed to put this lines in my .htaccess

# Binary Compressed files and archives
AddType application/zip .zip
AddType application/x-gzip .gz
AddType application/x-gtar .gtar
AddType application/x-rar-compressed .rar

so if someone have idea how to fix this ,it will be so helpful for me

Hello Eldewiny,

What in particular are you attempting to accomplish with the file types? Are you attempting to handle them differently within your script for each?

Thank you frist for your answer and here is the code what i use

<?php

function download($file){
$dir = './download/';
$path = $dir.$file;
if(!file_exists($path)){
die('Error');
}else{
header('Content-Description : File Transfer');
header('Content-Disposition : attachment; filename='.basename($path));
header('Content-Type: application/octet-stream');
header('Expires: 0');
header('Cache-Control: must-revalidate');
header('Pragma: public');
header('Content-Length: ' . filesize($file));
ob_clean();
ob_start();
flush();
readfile($path);
exit;
}
}
if (isset($_GET['download'])) {
if (!empty($_GET['download'])) {
$file = $_GET['download'];
download($file);
}
}
?>

<a class="download-template" href="example.php?download=modern.rar">Download</a>

The error was being caused by extra spaces within your header lines. Rewriting it to the following works just fine:

<?php
function download($file){
$dir = './download/';
$path = $dir.$file;
if(!file_exists($path)){
die('Error');
}else{
header('Content-Description: File Transfer');
header('Content-Disposition: attachment; filename='.basename($path));
header('Content-Type: application/octet-stream');
header('Expires: 0');
header('Cache-Control: must-revalidate');
header('Pragma: public');
header('Content-Length: ' . filesize($file));
ob_clean();
ob_start();
flush();
readfile($path);
exit;
}
}
if (isset($_GET['download'])) {
if (!empty($_GET['download'])) {
$file = $_GET['download'];
download($file);
}
}
?>

i update the code but i still get the same result i think it 's nothing todo with the code here is the link go down and under the image click the button and see the result

http://psdclass.com/example.php

These errors were being caused by the order in which your PHP includes were defined. As your header PHP include file was defined before the download script PHP include, the download script was unable to set the header information that is defined within it. I have reversed the two lines on your page so that the download script is called first, and as I see you have adjusted your previous code with that I provided previously, it appears to be working now.

OH MY GOD it is working thank you JeffMa so so much and nice to meet you

It has been my pleasure. One thing I would like to add is to avoid using GET requests to defined the file to be downloaded. This could be exploited to read from any file on your site and could cause your site to become hacked. I recommend directly linking to the file for download instead.

thank you for the advice i will take care about the rest of the code